feat(users): adding user graphql mutation #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ahub into gabe--addingUserMutations
jjoyce0510
reviewed
Feb 2, 2022
| } | ||
|
|
||
| private RecordTemplate mapCorpUserEditableInfo(CorpUserUpdateInput input, Optional<CorpUserEditableInfo> existing) { | ||
| CorpUserEditableInfo result = existing.orElseGet(() -> new CorpUserEditableInfo()); |
There was a problem hiding this comment.
Wow this is awesome - I love how this is basically a patch!
gabe-lyons
force-pushed
the
gabe--addingUserMutations
branch
from
85455ae to
6f817a1
Compare
jjoyce0510
reviewed
Feb 3, 2022
| @@ -592,6 +592,7 @@ private void configureMutationResolvers(final RuntimeWiring.Builder builder) { | |||
| .dataFetcher("updateDashboard", new AuthenticatedResolver<>(new MutableTypeResolver<>(dashboardType))) | |||
| .dataFetcher("updateDataJob", new AuthenticatedResolver<>(new MutableTypeResolver<>(dataJobType))) | |||
| .dataFetcher("updateDataFlow", new AuthenticatedResolver<>(new MutableTypeResolver<>(dataFlowType))) | |||
| .dataFetcher("updateCorpUserProperties", new AuthenticatedResolver<>(new MutableTypeResolver<>(corpUserType))) | |||
There was a problem hiding this comment.
Any reason we went specific here? Instead of saying "updateCorpUser" like the others?
shirshanka
approved these changes
Feb 3, 2022
shirshanka
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist