Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): Not failing on table/view ingestion error #4185

Merged

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 18, 2022

Unit Test Results (build & test)

  70 files  ±0    70 suites  ±0   13m 4s ⏱️ -33s
611 tests ±0  551 ✔️  - 1  59 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit fa1331a. ± Comparison against base commit 93befda.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 18, 2022

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   39m 7s ⏱️ - 6m 19s
   332 tests  - 12     332 ✔️ +  6    0 💤 ±0  0  - 6 
1 531 runs  +15  1 493 ✔️ +25  38 💤 +8  0  - 6 

Results for commit fa1331a. ± Comparison against base commit 93befda.

This pull request removes 12 tests.
tests.integration.hive.test_hive
tests.integration.redshift-usage.test_redshift_usage
tests.integration.starburst-trino-usage.test_starburst_trino_usage
tests.integration.trino.test_trino
tests.unit.stateful_ingestion.provider.test_datahub_ingestion_checkpointing_provider
tests.unit.stateful_ingestion.provider.test_datahub_ingestion_reporting_provider
tests.unit.stateful_ingestion.state.test_checkpoint
tests.unit.test_airflow
tests.unit.test_mariadb_source
tests.unit.test_oracle_source
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit a4dc413 into datahub-project:master Feb 20, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es treff7es deleted the warn_on_table_view_ingestion_error branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants