Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix config typo for stateful ingestion #4202

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix(docs): fix config typo for stateful ingestion #4202

merged 1 commit into from
Feb 22, 2022

Conversation

jieqiu0630
Copy link
Contributor

@jieqiu0630 jieqiu0630 commented Feb 21, 2022 •
edited
Loading

Also removed some trailing whitespaces 😅

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

dexter-mh-lee
dexter-mh-lee approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   41m 10s ⏱️
   341 tests    341 ✔️   0 💤 0 ❌
1 552 runs  1 521 ✔️ 31 💤 0 ❌

Results for commit 8962faf.

shirshanka
shirshanka approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit c372b93 into datahub-project:master Feb 22, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@jieqiu0630 @maggiehays
Fix config typo in stateful ingestion README (datahub-project#4202)
ac47ebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jieqiu0630 @dexter-mh-lee @shirshanka