Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update default preview card description text #4796

Merged
merged 2 commits into from
May 3, 2022
Merged

fix(ui): update default preview card description text #4796

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9755e
fix(ui): update default preview card description text
ShubhamThakre Apr 29, 2022
87c0e88
fix: update pr comments
ShubhamThakre May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions datahub-web-react/src/app/entity/shared/components/styled/StripMarkdownText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ import styled from 'styled-components';
const RemoveMarkdownContainer = styled.div`
display: block;
overflow-wrap: break-word;
word-wrap: break-word;
overflow-x: hidden;
overflow-y: auto;
overflow: hidden auto;
white-space: nowrap;
width: 844px;
ShubhamThakre marked this conversation as resolved.
Show resolved Hide resolved
overflow: hidden;
text-overflow: ellipsis;
`;

export type Props = {
Expand Down
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/preview/DefaultPreviewCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export default function DefaultPreviewCard({
</TitleContainer>
{description && description.length > 0 && (
<DescriptionContainer>
<NoMarkdownViewer limit={200}>{description}</NoMarkdownViewer>
<NoMarkdownViewer limit={250}>{description}</NoMarkdownViewer>
</DescriptionContainer>
)}
{owners && owners.length > 0 && (
Expand Down