From 38afc22ba5d9e0b521dd6d344eb99d1c12ae4243 Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Tue, 24 May 2022 21:25:08 +0530 Subject: [PATCH 1/2] fix(ingest): remove new schema field usage --- .../src/datahub/ingestion/source/sql/sql_common.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py b/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py index 6c3138825eaf0b..65fa1b68ce642d 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py +++ b/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py @@ -1087,12 +1087,7 @@ def get_schema_fields_for_column( tags: Optional[List[str]] = None, ) -> List[SchemaField]: gtc: Optional[GlobalTagsClass] = None - is_partition_key: Optional[bool] = None if tags: - if Constants.TAG_PARTITION_KEY in tags: - is_partition_key = True - else: - is_partition_key = False tags_str = [make_tag_urn(t) for t in tags] tags_tac = [TagAssociationClass(t) for t in tags_str] gtc = GlobalTagsClass(tags_tac) @@ -1104,7 +1099,6 @@ def get_schema_fields_for_column( nullable=column["nullable"], recursive=False, globalTags=gtc, - isPartitioningKey=is_partition_key, ) if ( pk_constraints is not None From 6f9c3ad48c49612abcb4b0f13eb92b2c31a0d082 Mon Sep 17 00:00:00 2001 From: Aseem Bansal Date: Tue, 24 May 2022 21:48:14 +0530 Subject: [PATCH 2/2] remove extra import --- .../src/datahub/ingestion/source/sql/sql_common.py | 1 - 1 file changed, 1 deletion(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py b/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py index 65fa1b68ce642d..6c3bae6de46c37 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py +++ b/metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py @@ -92,7 +92,6 @@ ViewPropertiesClass, ) from datahub.telemetry import telemetry -from datahub.utilities.mapping import Constants from datahub.utilities.sqlalchemy_query_combiner import SQLAlchemyQueryCombinerReport if TYPE_CHECKING: