-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve versiondropdown design & set docs main to /features #9994
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
db07656
feat: improve dropdown design & set docs main to /features
yoonhyejin 87a52b4
Merge branch 'master' into docs/docs-landing-page
yoonhyejin 260a288
feat: add external link button
yoonhyejin 0a115b6
fix: add redirect
yoonhyejin 27769bb
fix: fix rendering error
yoonhyejin f691810
Merge branch 'master' into docs/docs-landing-page
yoonhyejin 064e8f8
fix: fix quickstartcard css
yoonhyejin fab2b6e
fix: fix featurecard css
yoonhyejin f3a3f02
Merge branch 'master' into docs/docs-landing-page
yoonhyejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ module.exports = { | |
}, | ||
items: [ | ||
{ | ||
to: "docs/", | ||
to: "docs/features", | ||
activeBasePath: "docs", | ||
label: "Docs", | ||
position: "right", | ||
|
@@ -116,11 +116,19 @@ module.exports = { | |
dropdownActiveClassDisabled: true, | ||
dropdownItemsAfter: [ | ||
{ | ||
href: "https://docs-website-irpoe2osc-acryldata.vercel.app/docs/", | ||
type: 'html', | ||
value: '<hr class="dropdown-separator" style="margin: 0.4rem;">', | ||
}, | ||
{ | ||
type: 'html', | ||
value: '<div style="font-size:0.875rem; padding: 0.25rem 0.5rem;"><b>Archived versions</b></div>', | ||
}, | ||
{ | ||
href: "https://docs-website-irpoe2osc-acryldata.vercel.app/docs/features", | ||
label: "0.11.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}, | ||
{ | ||
href: "https://docs-website-1gv2yzn9d-acryldata.vercel.app/docs/", | ||
href: "https://docs-website-1gv2yzn9d-acryldata.vercel.app/docs/features", | ||
label: "0.10.5", | ||
}, | ||
], | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a number of other pages where we link to the main docs/ page
it'd be easier to remove the existing page, and change the slug for "docs/features" to be "docs/"
however, I think we need to give the docs/features page a slight UI uplift before elevating it - it just looks slightly less crisp than the current docs/ main page