Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate and sort required packages #24

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 19, 2024

Pillow has a number of optional dependencies ("extras"), and some of them duplicate a package (defusedxml, olefile):

https://github.com/python-pillow/Pillow/blob/f8160b858aebf8b7bffdefba48735feac300a060/pyproject.toml#L41-L73

This means we get duplicates when running pispy pillow:

image

This PR de-duplicates them by putting them in a set first, and we might as well sort them too:

image

@davep
Copy link
Owner

davep commented Apr 19, 2024

Thanks, although I suspect what you've done here is a portion of what I'm intending to do when I address #20 (probably in a stream on Sunday or Monday).

@hugovk
Copy link
Contributor Author

hugovk commented Apr 19, 2024

That sounds even better, feel free to close this :)

@davep
Copy link
Owner

davep commented Apr 19, 2024

I'll keep it open for now as a very obvious note to self that this needs doing. 😁

@davep davep merged commit 49b0438 into davep:main Apr 22, 2024
@davep
Copy link
Owner

davep commented Apr 22, 2024

Merging this in as there's a couple of other things I think need looking into when it comes to #20, and this makes for a far cleaner display meanwhile.

@hugovk hugovk deleted the sorted-set branch April 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants