Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a first pass and I have some comments (I still need to do another two three passes for a full-on review):
types
module. It seems that it mostly provides types that are the result of callingtype
on some objects. It would be the first exported symbol that does not with the suffixType
AFAIU.format_spec
that in case there's interpolations, they're eagerly evaluated.=
symbol behaves differently to f-strings. F-strings actually behave the exact same way. If someoneast.parse
s an f-string, they'll get an AST tree very similar to ourTemplate.args
.