-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove configstore - fixing npm vulnerability #62
Conversation
@davewasmer do you have any comments with this PR? It would be really good to remove the vulnerability from Gatsby (which is dependant on this change) |
cc @zetlen |
should I keep #64 open upgrading |
The reason I opened this PR is because I'm pretty sure it's not used. So removing it would be preferable. If it turns out it is used then we can go with your PR. |
I believe Looks like that import was stripped in January 2018: I can't find its implementation in |
thanks @Js-Brecht. I will close mine #64 then to reduce confusion @zetlen |
Thanks for your patience, folks. I'm reviewing this now; I think it's likely that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Resolves https://www.npmjs.com/advisories/1213 and by extension gatsbyjs/gatsby#26128
I couldn't see any use of this package @davewasmer. Let me know if I'm incorrect.