Issue #244 iframe not resizing correctly when images are included in … #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e included in dynamically loaded content Added back support for checking each mutation for images. Replaced checked on image height/width with check on image.complete flag as height/width seem to be set in IE and Firefox with erroneous values, even if not set on the actual image tag. Replaced bind approach for registering image load event listener with actual event listener function to avoid registering multiple listeners for same image and also so the listener can be removed. Also added listener for error event so that images which fail to load are handled cleanly.
|
Thank you for this, I'll take a look at it next week when I have a bit more spare time. |
davidjbradshaw
added a commit
that referenced
this pull request
Aug 29, 2015
Issue #244 iframe not resizing correctly when images are included in …
|
Released in v3.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back support for checking each mutation for images. Replaced event listener optimization check on image height/width with check on image.complete flag as height/width seem to be set in IE and Firefox with erroneous values even if not set on the actual image tag. Replaced bind approach for
registering image load event listener with event listener function to avoid registering multiple listeners for same image and also so the listener can be removed. Also added listener for error event so that images which fail to load are handled cleanly.