Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onTapStart and onTapEnd #1

Open
souporserious opened this issue Sep 3, 2016 · 4 comments
Open

onTapStart and onTapEnd #1

souporserious opened this issue Sep 3, 2016 · 4 comments

Comments

@souporserious
Copy link

I know you want to keep the lib small. Wondering if we can add some extra callbacks though? I'm creating a Material design ripple and need an onStart and onEnd callback. And instead of handling it with two callbacks myself, it would be cool to utilize this lib for it since I need to listen for a tap anyways. So I was thinking the API could change to something like this:

var tapListener = createTapListener(element)

tapListener.onTapStart(function () {
})

tapListener.onTap(function () {
})

tapListener.onTapEnd(function () {
})

If this would be of interest to you I can try a PR. Just let me know :)

@souporserious
Copy link
Author

@davidtheclark any thoughts on this?

@davidtheclark
Copy link
Owner

On vacation right now, will get to this after I return.

On Sep 9, 2016, at 12:36 PM, Travis Arnold [email protected] wrote:

@davidtheclark any thoughts on this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@davidtheclark
Copy link
Owner

@souporserious That seems to me like a great idea! Open to a PR.

@souporserious
Copy link
Author

Awesome :) I'm busy right now, but when I get a chance I'll put together a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants