-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encode! and decode! #147
Comments
Not sure what this would require from Jiffy? Is the api already the same and I just need to add the ! function names that proxy through to the existing encode/decode functions or are you asking for more API option equivalence stuff? |
Adding Other option may be adding |
Do you know of an example for me to look at that gas the Elixir API layer?
I've only skimmed over the intro tutorial so I'm not super familar with the
ecosystem for that sort of mixed project. Not against adding such a thing
just don't want to have it be a non-standard thing if possible.
…On Thu, Jun 22, 2017 at 3:52 PM Andrew Dryga ***@***.***> wrote:
Adding ! functions would be a great start, but usually this means that
functions without ! return {:ok, binary} or {:error, reason} (I guess {ok,
Binary} and {error, Reason}` in Erlang) tuples. Since this is a breaking
change I guess you can consider it only on next major update.
Other option may be adding mix.exs file and Elixir module, that will use
existing Erlang jiffy implementation and provide a Poison-compatible
interface, which won't break anything and will make using this package even
simpler.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#147 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABN2TKZ8-IAzPLe-K8rDJzUBzHyzLb-ks5sGtQEgaJpZM4OA-S0>
.
|
See #149 |
It would be really awesome to have Jiffy API fully compatible with Poison and ExJSX, so it can be used as a drop-in replacement in most of the projects.
The text was updated successfully, but these errors were encountered: