Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/development' into development-dax
Browse files Browse the repository at this point in the history
* upstream/development:
  enable `match.expand_envvars`
  fix: fix some typos in comments
  Bump softprops/action-gh-release from 1 to 2
  Bump microsoft/setup-msbuild from 1 to 2 (cmderdev#2917)
  Bump peter-evans/create-pull-request from 5 to 6 (cmderdev#2918)
  Bump actions/upload-artifact from 3 to 4 (cmderdev#2905)
  Do CI on development PRs
  Bump github/codeql-action from 2 to 3 (cmderdev#2906)
  • Loading branch information
daxgames committed May 22, 2024
2 parents 1ed3a36 + aac7cfc commit 5d80371
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 15 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
tags:
- "v*"
pull_request:
branches: [ "master" ]
branches: [ "master", "development" ]

#---------------------------------#
# environment configuration #
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
fetch-depth: 0

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v1
uses: microsoft/setup-msbuild@v2

- name: Build Cmder Launcher
shell: pwsh
Expand Down Expand Up @@ -72,32 +72,32 @@ jobs:
name: cmder_wt_mini.zip

- name: Upload artifact (cmder.zip)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: build/cmder.zip
name: cmder.zip
if-no-files-found: error

- name: Upload artifact (cmder.7z)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: build/cmder.7z
name: cmder.7z

- name: Upload artifact (cmder_mini.zip)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: build/cmder_mini.zip
name: cmder_mini.zip

- name: Upload artifact (hashes.txt)
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: build/hashes.txt
name: hashes.txt

- name: Create Release
uses: softprops/action-gh-release@v1
uses: softprops/action-gh-release@v2
with:
files: |
build/cmder.zip
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ name: "CodeQL"

on:
push:
branches: [ "master" ]
branches: [ "master", "development" ]
paths-ignore:
- '**/*.md'
- '**/*.txt'
- '.github/**'
- '**/.gitignore'
pull_request:
# The branches below must be a subset of the branches above
branches: [ "master" ]
branches: [ "master", "development" ]
paths-ignore:
- '**/*.md'
- '**/*.txt'
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -60,14 +60,14 @@ jobs:
# queries: security-extended,security-and-quality

- name: Add MSBuild to PATH
uses: microsoft/setup-msbuild@v1
uses: microsoft/setup-msbuild@v2

- name: Build Cmder Launcher
shell: pwsh
working-directory: scripts
run: .\build.ps1 -Compile -verbose

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
- development
paths-ignore:
- '**/*.md'
- '**/*.txt'
Expand All @@ -12,6 +13,7 @@ on:
pull_request:
branches:
- master
- development
paths-ignore:
- '**/*.md'
- '**/*.txt'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vendor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
Set-GHVariable -Name LIST_UPDATED -Value $listUpdated.Trim(', ')
echo "UPDATE_MESSAGE<<<EOF`n$updateMessage`n<EOF" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
- uses: peter-evans/create-pull-request@v5
- uses: peter-evans/create-pull-request@v6
if: env.COUNT_UPDATED > 0
with:
title: 'Updates to `${{ env.COUNT_UPDATED }}` vendored dependencies'
Expand Down
2 changes: 1 addition & 1 deletion launcher/src/version.rc2.sample
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

/**
* WARNING: do NOT modify this file! the content of this file should be
* automatically genereted before AppVeyor builds using the
* automatically generated before AppVeyor builds using the
* respective .ps1 Powershell scripts.
*
*/
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ if ($Compile) {

Write-Verbose "Building the launcher..."

# Referene: https://docs.microsoft.com/visualstudio/msbuild/msbuild-command-line-reference
# Reference: https://docs.microsoft.com/visualstudio/msbuild/msbuild-command-line-reference
msbuild CmderLauncher.vcxproj /t:Clean,Build /p:configuration=Release /m

if ($LastExitCode -ne 0) {
Expand Down
4 changes: 4 additions & 0 deletions vendor/clink_settings.default
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# For explanation of these and other settings see:
# https://chrisant996.github.io/clink/clink.html

# name: Expand envvars when completing
# type: boolean
match.expand_envvars = True

# name: Sets how command history expansion is applied
# type: enum
# options: off,on,not_squoted,not_dquoted,not_quoted
Expand Down

0 comments on commit 5d80371

Please sign in to comment.