fix: add viewport for showing summary #1284
Open
+98
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Tpuljak
requested changes
Oct 23, 2024
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Tpuljak
requested changes
Oct 24, 2024
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Tpuljak
previously approved these changes
Oct 24, 2024
Signed-off-by: bryans-go <[email protected]>
|
@Tpuljak sorry the issue still need some work . |
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
|
Done. Screencast.from.2024-10-24.18-19-58.mp4 |
Tpuljak
previously approved these changes
Oct 25, 2024
idagelic
reviewed
Oct 25, 2024
Signed-off-by: Divanshu Grover <[email protected]>
|
@idagelic done ! |
idagelic
requested changes
Oct 25, 2024
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
idagelic
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Yes, this seems to have fixed the env vars shuffling issue. Good work.
I have noticed some issues regarding displaying environment variables.
Here are a project-config add and a multiproject example:
Project config add - some env vars missing, scrolling does not do anything
Multi-project creation - sample-go project env vars are not shown
I see the env var display although better is not perfect on main either. Let me know if this is an easy fix as a part of this PR. Otherwise I will just open another issue for it
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
|
@idagelic Done ! |
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
idagelic
requested changes
Oct 31, 2024
|
@divanshu-go any updates for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add viewport for showing project / workspace summary
Description
this PR adds support for scrollable project summary by adding viewport
Related Issue(s)
Closes #1283
Closes #1298
Screenshots
Screencast.from.2024-10-23.12-17-49.mp4
Notes
Please add any relevant notes if necessary.