Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it optional to show lines with env vars when creating workspace #1337

Open
nkkko opened this issue Nov 13, 2024 · 3 comments
Open

make it optional to show lines with env vars when creating workspace #1337

nkkko opened this issue Nov 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@nkkko
Copy link
Member

nkkko commented Nov 13, 2024

Now when you create a workspace log that you see while it is created contains all env vars. This is inconvenient as user can accidentally leak the env vars if he is screen sharing/recording or just pasting logs to support.

@nkkko nkkko added the enhancement New feature or request label Nov 13, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Nov 14, 2024

We can use the secrets-file option of the devcontianer CLI which will mask the env vars in the output.

@nkkko
Copy link
Member Author

nkkko commented Nov 14, 2024

This still doesn't eliminate risk if we keep the way things are now?

@Tpuljak
Copy link
Member

Tpuljak commented Nov 14, 2024

This still doesn't eliminate risk if we keep the way things are now?

I'm saying that we should implement adding env vars to devcontainers using the secrets-file option as part of this issue. This will eliminate the risk of env vars leaking into the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants