feat: add server log files selection #1345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
lbrecic
force-pushed
the
server-logs-select
branch
from
59490c6
to
0644b54
Compare
Tpuljak
requested changes
Nov 19, 2024
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
Tpuljak
requested changes
Nov 20, 2024
Signed-off-by: Luka Brecic <[email protected]>
Tpuljak
requested changes
Nov 21, 2024
Signed-off-by: Luka Brecic <[email protected]>
Tpuljak
requested changes
Nov 22, 2024
Signed-off-by: Luka Brecic <[email protected]>
Tpuljak
requested changes
Nov 22, 2024
Signed-off-by: Luka Brecic <[email protected]>
Tpuljak
previously approved these changes
Nov 22, 2024
idagelic
requested changes
Nov 22, 2024
pkg/cmd/server/logs.go
Outdated
There was a problem hiding this comment.
Can we move this into the pkg/cmd/server/logs dir since it now has a subcommand - to match the rest of the CLI
pkg/cmd/server/list.go
Outdated
| var listCmd = &cobra.Command{ | ||
| Use: "list", | ||
| Aliases: []string{"ls"}, | ||
| Short: "Output Daytona Server logs", |
There was a problem hiding this comment.
Looks like a leftover description, should say "Lists Daytona Server log files.." or something similar
| } | ||
| } | ||
|
|
||
| func getLogFileSelectionProgramEssentials(files []string) tea.Model { |
There was a problem hiding this comment.
I would be in favour of merging this function with the one above
Signed-off-by: Luka Brecic <[email protected]>
Signed-off-by: Luka Brecic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server log files selection & list server logs command
Description
This PR introduces server log files selection for reading upon running
daytona server logscommand.This naturally follows #1304 since now there is log rotation files that user might want to read from.
Log files included in selection follow instructions from lumberjack package where rotated log files are saved under
<process_name>-<timestamp>.logor<process_name>-<timestamp>.zipif compression is enabled through log file configuration. (<process_name>in this case isdaytona; main relevant log filedaytona.logis also included in selection)To avoid selection with non-interactive approach, user is able to specify a log file name using
--fileflag. In order to make this easier for user, this PR also introduces adaytona server logs listwhich outputs a list of log files from server.Related Issue(s)
Closes #1343
Screenrecording
Screen.Recording.2024-11-20.at.13.38.50.mov