-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'DeprecationWarning' for the use of 'Buffer without new
'
#104
Comments
new
'new
'
What node are you using? |
Version 7.2. |
Same issue. I downgraded to the LTS version of node 6.9.1 and the message doesn't show up |
I get the same warning. Node v7.2.0 Awesome lib, by the way, dbashford. Was about to begrudgingly write my own - lucky I found yours! |
Node team has been tinkering with Buffer and decided to push this deprecation warning. For more context, see nodejs/node#9531 Many modules have been affected by this. Supposedly it will be removed in 7.2.1: nodejs/node#9529 so I think we can just wait it out |
I'll take a look at this over the xmas break. Been slammed at work and had a 3rd kid a few months ago so my OSS time has been chopped to critical work related stuff. I do want to jump back into this and get a worthy |
@dbashford Congrats on the kid! you may need a new profile photo :D |
I've verified this happens with I ran the tests after having commented out every last bit of buffer stuff textract did and still got the error. And anyway, textract doesn't create buffers, it just uses the ones it is given. I have updated all the dependencies to the latest, with the exception of And I still get the deprecation. I suspect either a Going to close this out as there isn't much I can do now, and what it is that I could do (hunt through the dependencies looking for the offender) isn't worth the effort, at least until this is a real problem and not just a now-deprecated deprecation. =) Thanks for reporting it though! Gave me a reason to take a peek at how textract is doing in the 7s. |
The warning is as follows:
Caused by using
fromFileWithPath
andfromBufferWithName
. I have not tested the other functions.The text was updated successfully, but these errors were encountered: