Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not execute process_saved_queries if nothing in semantic manifest has changed #10563

Closed
gshank opened this issue Aug 13, 2024 · 1 comment · Fixed by #10784
Closed

Do not execute process_saved_queries if nothing in semantic manifest has changed #10563

gshank opened this issue Aug 13, 2024 · 1 comment · Fixed by #10784

Comments

@gshank
Copy link
Contributor

gshank commented Aug 13, 2024

Description

Currently we run process_saved_queries for every saved query in a manifest, even if nothing has changed in the semantic manifest. In the right circumstances this can be a performance problem.

Acceptance Criteria

Check for actual changes to the semantic manifest before executing process_saved_queries for every saved query.

@gshank
Copy link
Contributor Author

gshank commented Sep 24, 2024

Saved queries, metrics and semantic models are in the semantic manifest. In some cases semantic_models may be "scheduled for parsing" because a model that it refers to has changed, but nothing in the actual definition has changed. If we want to minimize the cases where we run process_saved_queries, it might make sense to create a flag in the partial parser ("semantic_manifest_changed") and set it if we encounter a saved query, metric or semantic model in "handle_schema_file_changes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant