Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-610] [Spike] Investigate if region is absolutely required #484

Closed
dbeatty10 opened this issue Jun 7, 2023 · 0 comments · Fixed by #485
Closed

[ADAP-610] [Spike] Investigate if region is absolutely required #484

dbeatty10 opened this issue Jun 7, 2023 · 0 comments · Fixed by #485
Assignees
Labels
type:bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

Question to answer

  • Is passing a region to redshift_connector absolutely necessary? i.e., must it be a breaking change in dbt-redshift 1.5?

Context

  1. The region was hard-coded to be parsed from the hostname when switching from psycopg2 to redshift_connector in Modify RedshiftConnectionManager to extend from SQLConnectionManager, migrate from psycopg2 to redshift python connector #251.
  2. An optional region config for dbt-redshift profiles was added in Fix for #419: dbt-redshift 1.5 does not work with non-standard redshift hostnames #420, but it still tries to infer the region from the host name when it is not provided.

See #419 for situations where the region can't be inferred from the host.

The redshift_connector docs have region listed as optional, so maybe there are scenarios in which we can omit supplying it.

Feedback

#419 (comment)

Looking into this, it seems like region isn't a required parameter at all at least if you are connecting with a username and password. Can we investigate if we can either not require region at all or only require it in situations where it is actually required?

See #483 for an additional request to make this non-breaking in 1.5.

@github-actions github-actions bot changed the title [Spike] Investigate if region is absolutely required [ADAP-610] [Spike] Investigate if region is absolutely required Jun 7, 2023
@dbeatty10 dbeatty10 added type:bug Something isn't working triage:product and removed triage:product labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants