Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getdate() instead of current_timestamp on Redshift impl of current_timestamp() macro #109

Closed
drewbanin opened this issue Jan 4, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@drewbanin
Copy link
Contributor

Existing code: https://github.com/fishtown-analytics/dbt-utils/blob/28bdf56915765f1ea9ab3e38584e3cb38992a700/macros/cross_db_utils/current_timestamp.sql#L5

The current_timestamp value on Redshift looks deprecated (via the docs). There have also been reports of current_timestamp returning the wrong time.

@drewbanin drewbanin added the bug Something isn't working label Jan 4, 2019
@tjengel
Copy link
Contributor

tjengel commented Oct 27, 2019

I'm trying to push a branch for this, but getting an error when trying to push to the repo

ERROR: Permission to fishtown-analytics/dbt-utils.git denied to tjengel.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Do I need to get access to push to this repo? Thanks

@drewbanin
Copy link
Contributor Author

hey @tjengel - you'll want to fork this repo into your own GitHub account (or an Organization that you're a member of). After that, you should be able to push your changes to a branch on your fork, then open up a PR from your forked repo into the dbt-utils repo. Let me know if there's anything I can help out with here

@tjengel
Copy link
Contributor

tjengel commented Oct 31, 2019

@drewbanin This should be ready for a CI build.

@tjengel
Copy link
Contributor

tjengel commented May 1, 2020

@drewbanin I think we can close this issue.

@drewbanin
Copy link
Contributor Author

ah, thanks @tjengel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants