Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: License Map Resource #178

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

SudoSpartanDan
Copy link
Contributor

This PR adds the ability to create/manage license maps within DBT Cloud.

@SudoSpartanDan
Copy link
Contributor Author

I seem to be having issues with the license type already existing in the acceptance test instance. Any possibility to look into the instance to see if a previous test was not cleaned up?

@b-per
Copy link
Collaborator

b-per commented Aug 7, 2023

There was one dangling mapping for the Developer license. I just removed it.

@SudoSpartanDan
Copy link
Contributor Author

There was one dangling mapping for the Developer license. I just removed it.

That did it, this PR is ready for review @b-per

@b-per b-per mentioned this pull request Aug 8, 2023
@b-per
Copy link
Collaborator

b-per commented Aug 8, 2023

Thanks a lot for getting it passing and for having an Acceptance Test!

I have created #179 to add some minor changes on top of your commits (I don't have access to push to your repo).

  • As the list of SSO groups is not ordered and should contain unique groups, it is more akin to a set than a list
  • I have updated the test to check when we are assigning multiple groups

So, when CI passes for #179 I will merge it and close this one

I will update the README and do a new release today as well

@b-per b-per merged commit d41aa7b into dbt-labs:main Aug 8, 2023
@SudoSpartanDan
Copy link
Contributor Author

Sounds great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants