Add Beta writable_environment_categories to dbtcloud_service_token
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acctests only failing on CI... Why?
|
CC: @b-per . Should be ready to go This was a long one, so lmk if I missed anything before merge |
b-per
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Thanks @chasewalden for doing all those changes 🙌
I added a few comments, some of them are just informative and do not require a code change.
In a nutshell, before merging it we could:
- update the tests so that we test the new feature
- update the docs with an example of how we set env level restrictions
- check whether we want to keep the
TODO(cwalden)in the code or remove those and maybe track future changes somewhere else
|
Lets fix the typo mentioned in #275 here as well. |
Seems to not work with my env. Not sure if there is an issue with writable_env_categories not available on my instance. I am getting weird errors. Will need to see if this passes with the CI env
Also fix typo mentioned in #275
|
Should have everything we need to Merge & Close. We can also close #275 with this as the fix to the typo is bundled in with this. |
b-per
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks @chasewalden for all the new changes.
I just left a few minor comments before we can merge it.
b-per
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.