Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Date header when trying to fetching date on not RFC compliant emails #438

Closed
pupaxxo opened this issue Dec 17, 2019 · 1 comment · Fixed by #439
Closed

Invalid Date header when trying to fetching date on not RFC compliant emails #438

pupaxxo opened this issue Dec 17, 2019 · 1 comment · Fixed by #439

Comments

@pupaxxo
Copy link
Contributor

pupaxxo commented Dec 17, 2019

Hi,

we saw a few messages using a date header like this 'Mon, 15 09 2014 05:25:04'. Of course this is not RFC-compliant. I don't know if it makes sense to add some sort of parsing.

Currently we are using a manual date reader to support these invalid formats.
@Slamdunk
Copy link
Collaborator

Hi, dates in email strictly follow the law of we-love-to-mess-everything-so-lets-shuffle.
This library is tested against the most common date formats: https://github.com/ddeboer/imap/blob/master/tests/MessageTest.php#L595

You can add that format to the test cases, and if the tests fail you can try to fix the algorithm, any PR is welcome

@pupaxxo pupaxxo mentioned this issue Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle comments (CFWS) in Date header + not-valid formats pupaxxo/imap
2 participants
@Slamdunk @pupaxxo