Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text output format not working #46

Open
john-cosnowski opened this issue Jan 18, 2016 · 4 comments
Open

text output format not working #46

john-cosnowski opened this issue Jan 18, 2016 · 4 comments

Comments

@john-cosnowski
Copy link

--outfmt text appears to be broken because underscore.string version 3.2.3 added map function.

output is:
Error formatting output data in mode 'text': undefined is not a function

@makevoid
Copy link

makevoid commented Feb 3, 2016

If somebody needs to hotfix, you can do it by simply removing a join here: makevoid@e011503

I suppose the "base" error is in underscore.strings, from their docs they say the map function shouldn't be required when underscore.strings is mixed in underscore and the two function collide.

This code from u.strings ( https://github.com/epeli/underscore.string/blob/c1f7b1fa64bd6cecbe05689c05e66f7df68d8797/exports.js#L5 ) is checking for map and should not include it but it seems to get mixed in anyway for some reason.

@kshamil76
Copy link

The package.json for underscore-cli is using "*" for underscore.string, which allows for broken compatibility (although in this case it probably would've broken anyway). We worked around this issue by adding a specific version of underscore.string to our package.json (not the underscore-cli package.json), which forces underscore-cli to use the working version.

Here is the version we are using: "underscore.string": "3.1.1"

@makevoid
Copy link

makevoid commented Feb 5, 2016

Maybe it can be locked on master until the issue is fixed?

@scien
Copy link

scien commented Feb 10, 2016

+1. just ran into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants