Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcl pack creates items that error when placed into builder #565

Open
cfravel opened this issue Jul 7, 2021 · 2 comments
Open

dcl pack creates items that error when placed into builder #565

cfravel opened this issue Jul 7, 2021 · 2 comments

Comments

@cfravel
Copy link

cfravel commented Jul 7, 2021

I've tried "dcl pack" on items from the DCL libary of smart-items and simple items of my own.
I have tried various versions of decentraland and decentraland-ecs.
When I place the item.zip into a new asset pack in the Builder, it reports:
"src/games.ts: Exported scenes are not allowed"

steps to reproduce:
Pull the arrow smart item from the DCL github
npm i
dcl build
dcl pack
drag the reslting item.zip into the Builder
// expected: it gets added
// actual: error: src/games.ts: Exported scenes are not allowed

@cfravel
Copy link
Author

cfravel commented Jul 11, 2021

Seems like the fix is to do a little cleanup on the item.zip file, most especially removing the src/game.ts file.
However, dont' remove the /bin directory, or you won't get the properties panel when you select the object in the builder editor.
Also, if you are using git, remove the .git directory.
you don't neet the .gitignore or .dclignore files, either.
You can rename the item.zip without harm.

@cfravel
Copy link
Author

cfravel commented Jul 11, 2021

This is still not fixed in 3.5.1. at ;least not on Windows.
At the least it shouldn't put src/gamet.ts (the test harness) into the item.zip file, because it makes it throw an error when adding it to an asset pack.

Other files that it tends to put into it that can/should be removed include

.git folder, if you are using git
.gitignore
I'm not sure, but probably package.json and .dclignore could be removed.
I like it that it puts any README.md into the item.zip, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant