Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Cannot read property 'tokenizePlaceholders' of undefined #848

Closed
yuchanns opened this issue Aug 19, 2020 · 2 comments · Fixed by #849
Closed

Cannot read property 'tokenizePlaceholders' of undefined #848

yuchanns opened this issue Aug 19, 2020 · 2 comments · Fixed by #849
Assignees
Labels
bug Something isn't working highlight-code Highlight code web component
Milestone

Comments

@yuchanns
Copy link

Related issue PrismJS/prism#1395

Cannot highlight code language php since The dependency for PHP has changed.

Solution: include the component markup-templating in addition.

@peterpeterparker peterpeterparker transferred this issue from deckgo/gatsby-remark-highlight-code Aug 19, 2020
@peterpeterparker peterpeterparker added bug Something isn't working highlight-code Highlight code web component labels Aug 19, 2020
@peterpeterparker
Copy link
Contributor

peterpeterparker commented Aug 19, 2020

Thx for the issue, you are right, for languages as PHP, other dependencies have to be loaded on the fly.

I should try fetch the definition before or at build time of our WC and use it to download on the fly what's needed.

@peterpeterparker peterpeterparker self-assigned this Aug 19, 2020
@peterpeterparker peterpeterparker added this to the v2.3.0 milestone Aug 19, 2020
@peterpeterparker peterpeterparker linked a pull request Aug 19, 2020 that will close this issue
@peterpeterparker
Copy link
Contributor

the issue has been solved and the web component has been spread in all our apps and in the gatsby plugin for which I published a new version/fix too.

thx for the issue @yuchanns 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working highlight-code Highlight code web component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants