Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] MP4 concatenation with Video PassThroughTrackStrategy does nothing #192

Open
joaocsousa opened this issue Jan 28, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@joaocsousa
Copy link

joaocsousa commented Jan 28, 2024

Maybe I misunderstood how this library works, but if I try to merge 2 mp4 files that are exactly the same, I assumed a PassThroughTrackStrategy would be enough and it would merge the 2 video files together. However when I do

Transcoder.into(output.fileDescriptor)
    .addDataSource(context, uri1)
    .addDataSource(context, uri2) // uri1 and uri2 are a copy of the same mp4 file
    .setVideoTrackStrategy(PassThroughTrackStrategy())
    .transcode()

I just get Validator has decided that the input is fine and transcoding is not necessary..

I was expecting this, but I would have expected to merging to take place. However the final output file is completely empty.

Is this expected behaviour, and if so Is there a way to make this work without a full video transcoding?

Thanks!

@natario1 natario1 added the bug Something isn't working label Aug 11, 2024
@natario1
Copy link
Member

It's a bug. Until it gets fixed, you should be able to work around the problem by passing WriteAlwaysValidator to setValidator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants