-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MutedAudio strategy for media without audio track #51
Comments
I feel like this should work already with the current library. What is the issue that you are having? |
I will provide more info here, now that TrimDataSource is completed. For now I need to do some tests with v0.7.4 before sending a PR.
Handling the null exception was not enough. For example if file-1 has a single track (video) and file-2 has both tracks, then the concatenation result should have an empty sound track until the timestamp of file-2. What used to happen was a shift of the audio track for file-2 starting at the beginning of file-1. |
I faced the same problem. But I tried to transcode one video without audio track. |
I found workaround for this case. |
@TemMax solution works but it is not an option if we try to concatenate 2 videos and one of them has an audio track: we want to keep the first audio track and extend it with a mute sound for the duration of the second video. |
I submitted a pull request to solve @TemMax workaround: https://github.com/natario1/Transcoder/pull/61 @natario1 The next thing that we would like the library to handle is to optionally fill the missing track sources by a mute sound and maybe even a black image for the missing video sources. |
I'm trying to concatenate multiple videos where some would be missing the audio track. Is this a feature you're planning to add to the library?
I tried some code changes, and I was able to concatenate when all files are missing the audio track (result would not have an audio track). I was also able to mute audio if the track was available in the source.
However, I was not able to create the empty buffer manually. Do you have any hints that could guide me to find the right steps. I have looked around, and didn't find any solutions similar to this.
The text was updated successfully, but these errors were encountered: