Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter names to convert_from_transformers call in question_answering_crossvalidation.py #672

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

julian-risch
Copy link
Member

Parameter names were missing, a change in the order of parameters caused a bug.
There were no other calls of this method that were missing parameter names.

…nswering_crossvalidation.py

Parameter names were missing, a change in the order of parameters caused a bug.
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I also checked the Inferencer.load call which has the new revision arg - seems fine for all occurrences as well.

@Timoeller Timoeller merged commit 1f046ca into master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants