Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #759 #772

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix for #759 #772

merged 2 commits into from
May 20, 2021

Conversation

johann-petrak
Copy link
Contributor

Moved the logger warning to the constructor

@johann-petrak johann-petrak mentioned this pull request May 19, 2021
Closed
Timoeller
Timoeller reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the warning for the InferenceProcessor in line 1010 as well, please?

Then we can merge asap

@johann-petrak
Copy link
Contributor Author

ah yes, thanks - done.

Timoeller
Timoeller approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks a lot!

@Timoeller Timoeller merged commit 0357634 into deepset-ai:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johann-petrak @Timoeller