Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove deprecated secret #33

Merged
merged 8 commits into from
Dec 3, 2024
Merged

feat: remove deprecated secret #33

merged 8 commits into from
Dec 3, 2024

Conversation

chaospuppy
Copy link
Contributor

@chaospuppy chaospuppy commented Nov 22, 2024 •
edited
Loading

Description

The top-level .secrets key is deprecated, but is left in the upstream chart, resulting in a pointless example secret called myminio-env-configuration being created which made troubleshooting more confusing.

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@chaospuppy chaospuppy requested a review from a team as a code owner November 22, 2024 22:19
@chaospuppy chaospuppy changed the title omit deprecated .secret field, allow for setting of app password in advance, do not reuse existing secret omit deprecated .secret field, allow for setting of app password in advance, do not reuse secret Nov 22, 2024
@chaospuppy chaospuppy changed the title omit deprecated .secret field, allow for setting of app password in advance, do not reuse secret update: omit .secret field, allow for setting app password in advance, do not reuse secret Nov 22, 2024
@chaospuppy chaospuppy changed the title update: omit .secret field, allow for setting app password in advance, do not reuse secret update: omit .secret field, set app password in advance Nov 22, 2024
@chaospuppy chaospuppy changed the title update: omit .secret field, set app password in advance feat: omit .secret field, set app password in advance Nov 22, 2024
@chaospuppy chaospuppy changed the title feat: omit .secret field, set app password in advance feat: remove deprecated secret Dec 2, 2024
Racer159
Racer159 requested changes Dec 2, 2024
View reviewed changes
values/tenant-values.yaml Outdated Show resolved Hide resolved
@Racer159 Racer159 added this to the Releases milestone Dec 3, 2024
@Racer159 Racer159 removed this from the Releases milestone Dec 3, 2024
@Racer159 Racer159 merged commit e4dcb45 into main Dec 3, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaospuppy @Racer159 @zachariahmiller