Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase gitlab webservice mem limit to recommended min #102

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sarnowski-defense-unicorns
Copy link
Contributor

Description

When using the dev bundle locally, observed consistent OOMKilled crashes of the webservice pod with current 2.5G memory limit, which is below the gitlab recommended minimum: https://docs.gitlab.com/charts/charts/gitlab/webservice/#memory-requestslimits

Increase limit to 3.5G to align with gitlab recommendations, but leave requests unchanged.

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 changed the title Increase gitlab webservice memory limit to recommended minimum fix: increase gitlab webservice memory limit to recommended minimum Sep 25, 2024
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, just requesting changes to block until i've validated testing locally.

@zachariahmiller zachariahmiller changed the title fix: increase gitlab webservice memory limit to recommended minimum fix: increase gitlab webservice mem limit to recommended min Sep 30, 2024
@zachariahmiller zachariahmiller merged commit 17e1ad4 into main Sep 30, 2024
8 of 9 checks passed
@zachariahmiller zachariahmiller deleted the increase-gitlab-webservice-memory-limit branch September 30, 2024 15:36
Racer159 added a commit that referenced this pull request Oct 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.7...v0.3.0)
(2024-10-25)


### Bug Fixes

* increase gitlab webservice mem limit to recommended min
([#102](#102))
([17e1ad4](17e1ad4))


### Miscellaneous

* badge, add renovate, update READMEs/workflow permissions
([#110](#110))
([258dbca](258dbca))
* **deps:** update swf bundle dependencies
([#100](#100))
([5f6dbc7](5f6dbc7))
* **deps:** update swf bundle dependencies
([#103](#103))
([f2e9b16](f2e9b16))
* **deps:** update swf bundle dependencies
([#109](#109))
([03b33dc](03b33dc))
* set fail-fast to true on test matrix
([#111](#111))
([13c3b6e](13c3b6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
Racer159 added a commit that referenced this pull request Oct 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.7...v0.3.0)
(2024-10-25)


### Bug Fixes

* increase gitlab webservice mem limit to recommended min
([#102](#102))
([17e1ad4](17e1ad4))


### Miscellaneous

* badge, add renovate, update READMEs/workflow permissions
([#110](#110))
([258dbca](258dbca))
* **deps:** update swf bundle dependencies
([#100](#100))
([5f6dbc7](5f6dbc7))
* **deps:** update swf bundle dependencies
([#103](#103))
([f2e9b16](f2e9b16))
* **deps:** update swf bundle dependencies
([#109](#109))
([03b33dc](03b33dc))
* fix the arm64 publish task
([#113](#113))
([58a4d7e](58a4d7e))
* set fail-fast to true on test matrix
([#111](#111))
([13c3b6e](13c3b6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
Racer159 added a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.7...v0.3.0)
(2024-10-25)


### Bug Fixes

* increase gitlab webservice mem limit to recommended min
([#102](#102))
([17e1ad4](17e1ad4))


### Miscellaneous

* badge, add renovate, update READMEs/workflow permissions
([#110](#110))
([258dbca](258dbca))
* **deps:** update swf bundle dependencies
([#100](#100))
([5f6dbc7](5f6dbc7))
* **deps:** update swf bundle dependencies
([#103](#103))
([f2e9b16](f2e9b16))
* **deps:** update swf bundle dependencies
([#109](#109))
([03b33dc](03b33dc))
* **deps:** update swf bundle dependencies
([#115](#115))
([ac4e1bd](ac4e1bd))
* fix the arm64 publish task
([#113](#113))
([58a4d7e](58a4d7e))
* set fail-fast to true on test matrix
([#111](#111))
([13c3b6e](13c3b6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
Racer159 added a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.7...v0.3.0)
(2024-10-25)


### Bug Fixes

* increase gitlab webservice mem limit to recommended min
([#102](#102))
([17e1ad4](17e1ad4))
* remove uds-runtime from bundle
([#117](#117))
([563928e](563928e))


### Miscellaneous

* badge, add renovate, update READMEs/workflow permissions
([#110](#110))
([258dbca](258dbca))
* **deps:** update swf bundle dependencies
([#100](#100))
([5f6dbc7](5f6dbc7))
* **deps:** update swf bundle dependencies
([#103](#103))
([f2e9b16](f2e9b16))
* **deps:** update swf bundle dependencies
([#109](#109))
([03b33dc](03b33dc))
* **deps:** update swf bundle dependencies
([#115](#115))
([ac4e1bd](ac4e1bd))
* fix the arm64 publish task
([#113](#113))
([58a4d7e](58a4d7e))
* set fail-fast to true on test matrix
([#111](#111))
([13c3b6e](13c3b6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants