-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase gitlab webservice mem limit to recommended min #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Sarnowski <[email protected]>
Racer159
changed the title
Increase gitlab webservice memory limit to recommended minimum
fix: increase gitlab webservice memory limit to recommended minimum
Sep 25, 2024
zachariahmiller
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine, just requesting changes to block until i've validated testing locally.
zachariahmiller
approved these changes
Sep 30, 2024
zachariahmiller
changed the title
fix: increase gitlab webservice memory limit to recommended minimum
fix: increase gitlab webservice mem limit to recommended min
Sep 30, 2024
Racer159
added a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.7...v0.3.0) (2024-10-25) ### Bug Fixes * increase gitlab webservice mem limit to recommended min ([#102](#102)) ([17e1ad4](17e1ad4)) ### Miscellaneous * badge, add renovate, update READMEs/workflow permissions ([#110](#110)) ([258dbca](258dbca)) * **deps:** update swf bundle dependencies ([#100](#100)) ([5f6dbc7](5f6dbc7)) * **deps:** update swf bundle dependencies ([#103](#103)) ([f2e9b16](f2e9b16)) * **deps:** update swf bundle dependencies ([#109](#109)) ([03b33dc](03b33dc)) * set fail-fast to true on test matrix ([#111](#111)) ([13c3b6e](13c3b6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]>
Racer159
added a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.7...v0.3.0) (2024-10-25) ### Bug Fixes * increase gitlab webservice mem limit to recommended min ([#102](#102)) ([17e1ad4](17e1ad4)) ### Miscellaneous * badge, add renovate, update READMEs/workflow permissions ([#110](#110)) ([258dbca](258dbca)) * **deps:** update swf bundle dependencies ([#100](#100)) ([5f6dbc7](5f6dbc7)) * **deps:** update swf bundle dependencies ([#103](#103)) ([f2e9b16](f2e9b16)) * **deps:** update swf bundle dependencies ([#109](#109)) ([03b33dc](03b33dc)) * fix the arm64 publish task ([#113](#113)) ([58a4d7e](58a4d7e)) * set fail-fast to true on test matrix ([#111](#111)) ([13c3b6e](13c3b6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]>
Racer159
added a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.7...v0.3.0) (2024-10-25) ### Bug Fixes * increase gitlab webservice mem limit to recommended min ([#102](#102)) ([17e1ad4](17e1ad4)) ### Miscellaneous * badge, add renovate, update READMEs/workflow permissions ([#110](#110)) ([258dbca](258dbca)) * **deps:** update swf bundle dependencies ([#100](#100)) ([5f6dbc7](5f6dbc7)) * **deps:** update swf bundle dependencies ([#103](#103)) ([f2e9b16](f2e9b16)) * **deps:** update swf bundle dependencies ([#109](#109)) ([03b33dc](03b33dc)) * **deps:** update swf bundle dependencies ([#115](#115)) ([ac4e1bd](ac4e1bd)) * fix the arm64 publish task ([#113](#113)) ([58a4d7e](58a4d7e)) * set fail-fast to true on test matrix ([#111](#111)) ([13c3b6e](13c3b6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]>
Racer159
added a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.7...v0.3.0) (2024-10-25) ### Bug Fixes * increase gitlab webservice mem limit to recommended min ([#102](#102)) ([17e1ad4](17e1ad4)) * remove uds-runtime from bundle ([#117](#117)) ([563928e](563928e)) ### Miscellaneous * badge, add renovate, update READMEs/workflow permissions ([#110](#110)) ([258dbca](258dbca)) * **deps:** update swf bundle dependencies ([#100](#100)) ([5f6dbc7](5f6dbc7)) * **deps:** update swf bundle dependencies ([#103](#103)) ([f2e9b16](f2e9b16)) * **deps:** update swf bundle dependencies ([#109](#109)) ([03b33dc](03b33dc)) * **deps:** update swf bundle dependencies ([#115](#115)) ([ac4e1bd](ac4e1bd)) * fix the arm64 publish task ([#113](#113)) ([58a4d7e](58a4d7e)) * set fail-fast to true on test matrix ([#111](#111)) ([13c3b6e](13c3b6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the dev bundle locally, observed consistent OOMKilled crashes of the webservice pod with current 2.5G memory limit, which is below the gitlab recommended minimum: https://docs.gitlab.com/charts/charts/gitlab/webservice/#memory-requestslimits
Increase limit to 3.5G to align with gitlab recommendations, but leave requests unchanged.
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging