Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_last_checkpoint does some unnecessary listing #1643

Closed
eeroel opened this issue Sep 19, 2023 · 0 comments · Fixed by #1644
Closed

get_last_checkpoint does some unnecessary listing #1643

eeroel opened this issue Sep 19, 2023 · 0 comments · Fixed by #1644
Labels
bug Something isn't working

Comments

@eeroel
Copy link
Contributor

eeroel commented Sep 19, 2023

Environment

Delta-rs version: 0.10.2

Bug

Not a bug but a performance issue. When running update_incremental on an already-loaded table, get_last_checkpoint lists files starting from the last checkpoint, even if the loaded table is at a later version. This causes listing to take more time than necessary, as listing could start from self.version if it is larger than the last checkpoint version.
https://github.com/delta-io/delta-rs/blob/fdebcd67b59ca36e22b455065a7a32888122de0e/rust/src/delta.rs#L419C21-L419C21
@eeroel eeroel added the bug Something isn't working label Sep 19, 2023
@eeroel eeroel mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid excess listing of log files eeroel/delta-rs
1 participant
@eeroel