node/http.ts http.request should support socketPath option

[loynoir]

Describe the bug

Steps to Reproduce

> var Docker = (await import('npm:[email protected]')).default
undefined
> var docker = new Docker({socketPath: '/var/run/docker.sock'});
undefined
> await docker.listContainers()
Uncaught TypeError: error sending request for url (http://localhost/containers/json): error trying to connect: tcp connect error: Connection refused (os error 111)
    at async mainFetch (internal:ext/fetch/26_fetch.js:267:14)
    at async fetch (internal:ext/fetch/26_fetch.js:491:9)
    at async ClientRequest._final (https://deno.land/[email protected]/node/http.ts:147:7)

Expected behavior

> var Docker = (await import('dockerode')).default
undefined
> var docker = new Docker({socketPath: '/var/run/docker.sock'});
undefined
> await docker.listContainers()
[
  {
    Id: ...

Environment

• OS: [e.g. Ubuntu 20.04, MacOS 11] ArchLinux
• deno version: 1.30.3
• std version: https://deno.land/[email protected]/node/http.ts:147:7

[loynoir]

minimal reproduce

void http.request(
  'http://localhost/version',
  {
    socketPath: '/var/run/docker.sock',
  },
  (res) => res.on('data', (c) => console.log('' + c)),
).end()

Expected

$ node
> void http.request('http://localhost/version', {socketPath: '/var/run/docker.sock'}, (res)=>res.on('data',c=>console.log(''+c))).end()
// {"Platform": ...

Actual

$ deno
> import http from 'node:http'
> void http.request('http://localhost/version', {socketPath: '/var/run/docker.sock'}, (res)=>res.on('data',c=>console.log(''+c))).end()
// nothing

[loynoir]

@kt3k

#8821 (comment)

https://deno.land/x/[email protected]/mod.ts

Maybe can merge that library into node/http.ts logic?

[danopia]

https://deno.land/x/[email protected]/mod.ts

Maybe can merge that library into node/http.ts logic?

Unfortunately my socket_fetch library is incomplete :( It can only perform GET requests and is not optimized. I use it to query specific things but it's not in a shape to be dropped into npm libraries I think.

Ideally Deno ships some sort of Unix socket fetch client instead :)

[loynoir]

Workaround

import { fetch, Agent } from 'undici'

const resp = await fetch('http://localhost/version', {
  dispatcher: new Agent({
    connect: {
      socketPath: '/var/run/docker.sock'
    }
  })
})

console.log(await resp.text())

$ deno run --unstable -A ./reproduce.mjs
{"Platform":...

[loynoir]

Related

[feat] Make backend js ecosystem future better

nodejs/node#50195