Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type definition related to resizable ArrayBuffer. #19191

Closed
dojyorin opened this issue May 19, 2023 · 10 comments
Closed

Missing type definition related to resizable ArrayBuffer. #19191

dojyorin opened this issue May 19, 2023 · 10 comments
Labels
bug Something isn't working correctly

Comments

@dojyorin
Copy link

The resizable ArrayBuffer seems to be re-enabled, but the type definition are missing.
Is it the effect of being temporarily disabled...?

Environment

  • Windows 10 x64
  • VSCode v1.78.2
  • Deno v1.33.4
  • Deno VSCode Extension v3.18.0

deno-rab-issue-1
deno-rab-issue-2
deno-rab-issue-3
deno-rab-issue-4

@dsherret dsherret added bug Something isn't working correctly good first issue Good for newcomers labels Jun 8, 2023
@indrajitbnikam
Copy link

Can I work on this issue? Also, @dsherret Can you guide me a bit since this is my first OSS contribution?

@indrajitbnikam
Copy link

How can I generate types?

@petamoriken
Copy link
Contributor

petamoriken commented Jun 11, 2023

@indrajitbnikam Maybe you can try to contribute to upstream. There are d.ts files in /src/lib directory. Deno's /cli/tsc/dts directory is copied from TypeScript.

@dsherret dsherret removed the good first issue Good for newcomers label Jun 12, 2023
@dsherret
Copy link
Member

Ah, right. I forgot this would probably be updating TypeScript.

@indrajitbnikam
Copy link

Yes, I'm working on it.

@indrajitbnikam
Copy link

I've created an Issue and have also raised the PR for the same in upstream. Can somebody please check and let me know what more needs to be done?

@indrajitbnikam
Copy link

Hi, Can someone tell me what I need to put here in Configuration Check section for this issue? I did not change it while creating the issue.

image

Sorry, This is my first contribution so a lot of things are new for me.

@petamoriken
Copy link
Contributor

Upstream: microsoft/TypeScript#58573

@petamoriken
Copy link
Contributor

Tracking in #26950

@dsherret
Copy link
Member

Yeah, let's track this in #26950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants