Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp - Do not pass around RwLock in DiagnosticsServer #20658

Closed
dsherret opened this issue Sep 24, 2023 · 0 comments · Fixed by #20665
Closed

lsp - Do not pass around RwLock in DiagnosticsServer #20658

dsherret opened this issue Sep 24, 2023 · 0 comments · Fixed by #20665
Labels
chore something that we should get around to eventually lsp related to the language server

Comments

@dsherret
Copy link
Member

This makes the code more prone to deadlocks:

https://github.com/denoland/deno/pull/20632/files/440121697557bcdda0ef5f7799471a55470f1ef5#r1335218921
@dsherret dsherret added chore something that we should get around to eventually lsp related to the language server labels Sep 24, 2023
@dsherret dsherret mentioned this issue Sep 24, 2023
Merged
@nayeemrmn nayeemrmn mentioned this issue Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore something that we should get around to eventually lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): cache all dependencies quick fix nayeemrmn/deno
1 participant
@dsherret