Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a string when transpiling #282

Closed
dsherret opened this issue Oct 25, 2024 · 0 comments · Fixed by #283
Closed

Return a string when transpiling #282

dsherret opened this issue Oct 25, 2024 · 0 comments · Fixed by #283
Labels
perf

Comments

@dsherret
Copy link
Member

dsherret commented Oct 25, 2024 •
edited
Loading

The JsWriter API uses a Vec<u8>, but I believe this can be converted to a String unchecked because it's working from strings. This would be beneficial because then we could pass the string to deno_core as a known utf8 string.

See denoland/deno#26555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: return a string when transpiling dsherret/deno_ast
1 participant
@dsherret