From 0354ece21d9911d9db5fe278c63ccfdf99091f61 Mon Sep 17 00:00:00 2001 From: Risto Stevcev Date: Thu, 18 Feb 2021 03:26:38 +0100 Subject: [PATCH 1/3] Added ocamllsp --- ale_linters/ocaml/ocamllsp.vim | 13 +++++++++ autoload/ale/handlers/ocamllsp.vim | 23 +++++++++++++++ doc/ale-ocaml.txt | 15 ++++++++++ doc/ale-supported-languages-and-tools.txt | 1 + doc/ale.txt | 1 + supported-tools.md | 1 + .../ocamllsp_paths/dune-project | 0 .../test_ocaml_ocamllsp_callbacks.vader | 29 +++++++++++++++++++ 8 files changed, 83 insertions(+) create mode 100644 ale_linters/ocaml/ocamllsp.vim create mode 100644 autoload/ale/handlers/ocamllsp.vim create mode 100644 test/command_callback/ocamllsp_paths/dune-project create mode 100644 test/command_callback/test_ocaml_ocamllsp_callbacks.vader diff --git a/ale_linters/ocaml/ocamllsp.vim b/ale_linters/ocaml/ocamllsp.vim new file mode 100644 index 0000000000..4ff7419c2e --- /dev/null +++ b/ale_linters/ocaml/ocamllsp.vim @@ -0,0 +1,13 @@ +" Author: Risto Stevcev +" Description: The official language server for OCaml + +call ale#Set('ocaml_ocamllsp_use_opam', 1) + +call ale#linter#Define('ocaml', { +\ 'name': 'ocamllsp', +\ 'lsp': 'stdio', +\ 'executable': function('ale#handlers#ocamllsp#GetExecutable'), +\ 'command': function('ale#handlers#ocamllsp#GetCommand'), +\ 'language': function('ale#handlers#ocamllsp#GetLanguage'), +\ 'project_root': function('ale#handlers#ocamllsp#GetProjectRoot'), +\}) diff --git a/autoload/ale/handlers/ocamllsp.vim b/autoload/ale/handlers/ocamllsp.vim new file mode 100644 index 0000000000..07d9b0cf24 --- /dev/null +++ b/autoload/ale/handlers/ocamllsp.vim @@ -0,0 +1,23 @@ +" Author: Risto Stevcev +" Description: Handlers for the official OCaml language server + +function! ale#handlers#ocamllsp#GetExecutable(buffer) abort + return 'ocamllsp' +endfunction + +function! ale#handlers#ocamllsp#GetCommand(buffer) abort + let l:executable = ale#handlers#ocamllsp#GetExecutable(a:buffer) + let l:ocaml_ocamllsp_use_opam = ale#Var(a:buffer, 'ocaml_ocamllsp_use_opam') + + return l:ocaml_ocamllsp_use_opam ? 'opam config exec -- ' . l:executable : l:executable +endfunction + +function! ale#handlers#ocamllsp#GetLanguage(buffer) abort + return getbufvar(a:buffer, '&filetype') +endfunction + +function! ale#handlers#ocamllsp#GetProjectRoot(buffer) abort + let l:dune_project_file = ale#path#FindNearestFile(a:buffer, 'dune-project') + + return !empty(l:dune_project_file) ? fnamemodify(l:dune_project_file, ':h') : '' +endfunction diff --git a/doc/ale-ocaml.txt b/doc/ale-ocaml.txt index 8b644c1704..afbc2386e1 100644 --- a/doc/ale-ocaml.txt +++ b/doc/ale-ocaml.txt @@ -10,6 +10,21 @@ merlin *ale-ocaml-merlin* detailed instructions (https://github.com/the-lambda-church/merlin/wiki/vim-from-scratch). +=============================================================================== +ocamllsp *ale-ocaml-ocamllsp* + + The `ocaml-lsp-server` is the official OCaml implementation of the Language + Server Protocol. See the installation instructions: + https://github.com/ocaml/ocaml-lsp#installation + +g:ale_ocaml_ocamllsp_use_opam *g:ale_ocaml_ocamllsp_use_opam* + *b:ale_ocaml_ocamllsp_use_opam* + Type: |Number| + Default: `get(g:, 'ale_ocaml_ocamllsp_use_opam', 1)` + + This variable can be set to change whether or not opam is used to execute + the language server. + =============================================================================== ols *ale-ocaml-ols* diff --git a/doc/ale-supported-languages-and-tools.txt b/doc/ale-supported-languages-and-tools.txt index 33771e4995..c97019252b 100644 --- a/doc/ale-supported-languages-and-tools.txt +++ b/doc/ale-supported-languages-and-tools.txt @@ -330,6 +330,7 @@ Notes: * `merlin` (see |ale-ocaml-merlin|) * `ocamlformat` * `ocp-indent` + * `ocamllsp` * `ols` * OpenApi * `ibm_validator` diff --git a/doc/ale.txt b/doc/ale.txt index ad73eed298..93a157b600 100644 --- a/doc/ale.txt +++ b/doc/ale.txt @@ -2843,6 +2843,7 @@ documented in additional help files. uncrustify............................|ale-objcpp-uncrustify| ocaml...................................|ale-ocaml-options| merlin................................|ale-ocaml-merlin| + ocamllsp..............................|ale-ocaml-ocamllsp| ols...................................|ale-ocaml-ols| ocamlformat...........................|ale-ocaml-ocamlformat| ocp-indent............................|ale-ocaml-ocp-indent| diff --git a/supported-tools.md b/supported-tools.md index acaad7669e..d13c345cc8 100644 --- a/supported-tools.md +++ b/supported-tools.md @@ -339,6 +339,7 @@ formatting. * [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-ocaml-merlin` for configuration instructions * [ocamlformat](https://github.com/ocaml-ppx/ocamlformat) * [ocp-indent](https://github.com/OCamlPro/ocp-indent) + * [ocamllsp](https://github.com/ocaml/ocaml-lsp) * [ols](https://github.com/freebroccolo/ocaml-language-server) * OpenApi * [ibm_validator](https://github.com/IBM/openapi-validator) diff --git a/test/command_callback/ocamllsp_paths/dune-project b/test/command_callback/ocamllsp_paths/dune-project new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/command_callback/test_ocaml_ocamllsp_callbacks.vader b/test/command_callback/test_ocaml_ocamllsp_callbacks.vader new file mode 100644 index 0000000000..ff44beb418 --- /dev/null +++ b/test/command_callback/test_ocaml_ocamllsp_callbacks.vader @@ -0,0 +1,29 @@ +Before: + call ale#assert#SetUpLinterTest('ocaml', 'ocamllsp') + + Save &filetype + let &filetype = 'ocaml' + +After: + call ale#assert#TearDownLinterTest() + +Execute(The language string should be correct): + AssertLSPLanguage 'ocaml' + +Execute(The project root should be detected correctly): + AssertLSPProject '' + + call ale#test#SetFilename('ocamllsp_paths/file.ml') + + AssertLSPProject ale#path#Simplify(g:dir . '/ocamllsp_paths') + +Execute(The executable should be run using opam exec by default): + call ale#test#SetFilename('ocamllsp_paths/file.ml') + + AssertLinter 'ocamllsp', 'opam exec -- ocamllsp' + +Execute(The executable should be run directly if use_opam flag is disabled): + let g:ale_ocaml_ocamllsp_use_opam = 0 + call ale#test#SetFilename('ocamllsp_paths/file.ml') + + AssertLinter 'ocamllsp', 'ocamllsp' From 0cd00c01c17099ce678a6dadc738ef77cdbf187a Mon Sep 17 00:00:00 2001 From: Risto Stevcev Date: Thu, 18 Feb 2021 13:20:48 +0100 Subject: [PATCH 2/3] Update ordering in docs to be alphabetical --- doc/ale-supported-languages-and-tools.txt | 2 +- supported-tools.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ale-supported-languages-and-tools.txt b/doc/ale-supported-languages-and-tools.txt index c97019252b..3744df3c81 100644 --- a/doc/ale-supported-languages-and-tools.txt +++ b/doc/ale-supported-languages-and-tools.txt @@ -329,8 +329,8 @@ Notes: * OCaml * `merlin` (see |ale-ocaml-merlin|) * `ocamlformat` - * `ocp-indent` * `ocamllsp` + * `ocp-indent` * `ols` * OpenApi * `ibm_validator` diff --git a/supported-tools.md b/supported-tools.md index d13c345cc8..0b6fa73fce 100644 --- a/supported-tools.md +++ b/supported-tools.md @@ -338,8 +338,8 @@ formatting. * OCaml * [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-ocaml-merlin` for configuration instructions * [ocamlformat](https://github.com/ocaml-ppx/ocamlformat) - * [ocp-indent](https://github.com/OCamlPro/ocp-indent) * [ocamllsp](https://github.com/ocaml/ocaml-lsp) + * [ocp-indent](https://github.com/OCamlPro/ocp-indent) * [ols](https://github.com/freebroccolo/ocaml-language-server) * OpenApi * [ibm_validator](https://github.com/IBM/openapi-validator) From 700e0104e1f7a01e5297aea432e2d2317146f23d Mon Sep 17 00:00:00 2001 From: Risto Stevcev Date: Thu, 18 Feb 2021 14:11:14 +0100 Subject: [PATCH 3/3] Updated expected result in test --- test/command_callback/test_ocaml_ocamllsp_callbacks.vader | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/command_callback/test_ocaml_ocamllsp_callbacks.vader b/test/command_callback/test_ocaml_ocamllsp_callbacks.vader index ff44beb418..90a7e1a143 100644 --- a/test/command_callback/test_ocaml_ocamllsp_callbacks.vader +++ b/test/command_callback/test_ocaml_ocamllsp_callbacks.vader @@ -20,7 +20,7 @@ Execute(The project root should be detected correctly): Execute(The executable should be run using opam exec by default): call ale#test#SetFilename('ocamllsp_paths/file.ml') - AssertLinter 'ocamllsp', 'opam exec -- ocamllsp' + AssertLinter 'ocamllsp', 'opam config exec -- ocamllsp' Execute(The executable should be run directly if use_opam flag is disabled): let g:ale_ocaml_ocamllsp_use_opam = 0