Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: v3 delivery status callback #1616

Closed
3 tasks
kalbfled opened this issue Jan 23, 2024 · 1 comment
Closed
3 tasks

BUG: v3 delivery status callback #1616

kalbfled opened this issue Jan 23, 2024 · 1 comment

Comments

@kalbfled
Copy link
Member

kalbfled commented Jan 23, 2024

Description

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

After Notify makes an HTTP request to a provider and receives a 200 response, the provider should make HTTP requests to the delivery status callback endpoints to update the notification status in the Notify database. The status is not being updated.

Steps to Reproduce

  1. Send a notification to your self with a v3 endpoint.
  2. Wait until you receive the notification.
  3. GET the notification, and note that it remains in "sent" status.

Impact/Urgency

Expected Behavior

  • Notifications progress from "created," to "sent," . . . , to "delivered."

QA Considerations

  • refactor regression tests to account for this update

Additional Info & Resources

The status is being set to "sent" when sending the notification in app/celery/v3/notification_tasks.py

  • see v3 code here
  • Notifications should be sent to "sending" when sending to the provider
@cris-oddball
Copy link

NOTE: in testing #1770 we discovered that this bug prevents the email statuses being sent back to VAProfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants