-
-
Notifications
You must be signed in to change notification settings - Fork 187
Alpine linux incompatibility #966
Comments
To be more specific it causes a PHP notice:
But the worse problem is that aside of throwing this notice webalize can potentially return an empty string even if the input was not empty. Symplify doesn't actually fail, I just see the notice in the log but it is potentially dangerous. |
Is that Symplify or Nette? Solutions? |
It's a problem in Nette, unfortunately there is no known solution. Even detecting the issue to throw an exception instead of bad silent behaviour is difficult. The problem in Symplify is that it should not use a Nette function with such known issues. As for solution I would simply use md5 instead of webalize in this case. I mean it's just a directory name for cache so the value doesn't matter, right? |
If you're asking what to use instead of webalize to generate slugs (which is not the case here) then I can recommend cocur/slugify. |
The namespace is easier to debug while human readble. Could you send slugify PR for all webalize occurrences? |
There are only two other occurrences.
|
Same goes for paths. I think propper solution is install the PHP extension rather than switching packages due to minor incompatible Linux version. |
It's not a question of missing PHP extension, the extension is there but unfortunately works a bit differently than normal. It can't be solved easily. |
Still, it's responsbility of Nette or the Linux. Fixing it here is postponing such responsbility with band-aid instead of curing it. |
I agree but unfortunately there is no way to fix it correctly. |
Related: nette/utils#109 |
You recently added a
FilesystemCacheFactory
which usesStrings::webalize()
. The problem is that webalize internally callsiconv
withASCII//TRANSLIT//IGNORE
which doesn't work on Alpine.The text was updated successfully, but these errors were encountered: