-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node & Session aware locking #62
Comments
@chrisgilmerproj I completed my modifications. Are you interested in a PR? |
Yes please! |
Great to hear! I'll get it over by the end of the day |
So I private forked it and made the mods here https://github.com/Gage-Technologies/safelock I'm going to personally fork it and copy the changes so I can PR easily |
@chrisgilmerproj not sure if you saw it but here's the pr #63 |
@chrisgilmerproj I found a bug in the latest merge. The usage of newline for separation can have collisions with the little endian endcoded session ids. It's common enough that after about 4 million file locks I've found 50k deadlocks. I've traded out the separator for |
No problem @sam-ulrich1 . Send a PR and I'll approve it. |
Reviewed and merged! |
I am looking at implementing a node and session aware version of this lib. Would you be interested in a PR instead?
Goal:
In the case that a node is improperly terminated, deadlocks on the fs can be detected and automatically repaired at runtime.
Changes:
The text was updated successfully, but these errors were encountered: