Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akmal / fix: mismatch duration values #17698

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

akmal-deriv
Copy link
Contributor

Changes:

This fix resolves issues with mismatched duration values, ensuring accurate synchronization between user input and the system.

  1. Value Correction: Align duration values to eliminate inconsistencies during trade setup.
  2. Improved Accuracy: Ensure the duration input reflects the correct values across all components.
  3. Enhanced User Experience: Prevent confusion caused by mismatched durations, allowing for seamless trade configuration.

This fix improves reliability by addressing and correcting mismatched duration values.

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 10, 2024 5:19pm

@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12260524225

Details

  • 14 of 38 (36.84%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 53.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/Stores/Modules/Trading/trade-store.ts 3 5 60.0%
packages/trader/src/AppV2/Components/TradeParameters/Duration/duration.tsx 2 7 28.57%
packages/trader/src/AppV2/Components/TradeParameters/Duration/day.tsx 5 22 22.73%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Components/TradeParameters/Duration/day.tsx 1 59.41%
packages/trader/src/AppV2/Components/TradeParameters/Duration/container.tsx 2 94.83%
packages/trader/src/AppV2/Components/TradeParameters/Duration/duration.tsx 6 66.19%
Totals Coverage Status
Change from base Build 12259060491: -0.03%
Covered Lines: 32968
Relevant Lines: 57014

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17698](https://github.com/deriv-com/deriv-app/pull/17698)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-b-mismatch-duration.binary.sx?qa_server=red.derivws.com&app_id=31584
    - **Original**: https://deriv-app-git-fork-akmal-deriv-b-mismatch-duration.binary.sx
- **App ID**: `31584`

Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-b-mismatch-duration.binary.sx/

vinu-deriv
vinu-deriv previously approved these changes Dec 4, 2024
nijil-deriv
nijil-deriv previously approved these changes Dec 4, 2024
vinu-deriv
vinu-deriv previously approved these changes Dec 5, 2024
vinu-deriv
vinu-deriv previously approved these changes Dec 6, 2024
nijil-deriv
nijil-deriv previously approved these changes Dec 10, 2024
vinu-deriv
vinu-deriv previously approved these changes Dec 10, 2024
@nijil-deriv nijil-deriv merged commit 73b4c4d into deriv-com:master Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants