-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akmal / fix: mismatch duration values #17698
Merged
nijil-deriv
merged 8 commits into
deriv-com:master
from
akmal-deriv:b-mismatch-duration
Dec 11, 2024
Merged
Akmal / fix: mismatch duration values #17698
nijil-deriv
merged 8 commits into
deriv-com:master
from
akmal-deriv:b-mismatch-duration
Dec 11, 2024
+176
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12260524225Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-b-mismatch-duration.binary.sx/ |
vinu-deriv
previously approved these changes
Dec 4, 2024
ahmadtaimoor-deriv
approved these changes
Dec 4, 2024
henry-deriv
approved these changes
Dec 4, 2024
nijil-deriv
previously approved these changes
Dec 4, 2024
akmal-deriv
dismissed stale reviews from nijil-deriv and vinu-deriv
via
December 5, 2024 08:29
aff2889
vinu-deriv
previously approved these changes
Dec 5, 2024
vinu-deriv
previously approved these changes
Dec 6, 2024
ahmadtaimoor-deriv
approved these changes
Dec 6, 2024
nijil-deriv
previously approved these changes
Dec 10, 2024
vinu-deriv
previously approved these changes
Dec 10, 2024
henry-deriv
approved these changes
Dec 10, 2024
ahmadtaimoor-deriv
approved these changes
Dec 10, 2024
ahmadtaimoor-deriv
dismissed stale reviews from vinu-deriv and nijil-deriv
via
December 10, 2024 15:45
509349b
ahmadtaimoor-deriv
temporarily deployed
to
Preview
December 10, 2024 15:46 — with
GitHub Actions
Inactive
ahmadtaimoor-deriv
temporarily deployed
to
Preview
December 10, 2024 16:31 — with
GitHub Actions
Inactive
ahmadtaimoor-deriv
requested review from
dan-deriv,
matin-deriv and
yashim-deriv
as code owners
December 10, 2024 16:32
ahmadtaimoor-deriv
temporarily deployed
to
Preview
December 10, 2024 16:32 — with
GitHub Actions
Inactive
vinu-deriv
approved these changes
Dec 11, 2024
nijil-deriv
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This fix resolves issues with mismatched duration values, ensuring accurate synchronization between user input and the system.
This fix improves reliability by addressing and correcting mismatched duration values.