Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal calls onRequestClose when focused on a child element #124

Open
srph opened this issue Nov 1, 2015 · 4 comments
Open

Modal calls onRequestClose when focused on a child element #124

srph opened this issue Nov 1, 2015 · 4 comments
Labels
bug enhancement

Comments

@srph
Copy link
Contributor

srph commented Nov 1, 2015

Children of the modal.
@srph srph added the bug label Nov 1, 2015
@JefMari
Copy link
Contributor

JefMari commented Nov 3, 2015

how can i address this issue?

@srph
Copy link
Contributor Author

srph commented Nov 3, 2015

By checking the focused element. This is a bit detail-oriented and accessibility.

If an input is selected, pressing esc shouldn't call onRequestClose. But this might be unperformant. Even react-modal doesn't do this yet.

@JefMari
Copy link
Contributor

JefMari commented Nov 3, 2015

Bootstrap modal don't do this also. But ill try to find a way about this. 👍

@srph
Copy link
Contributor Author

srph commented Nov 3, 2015

If they don't, might as well close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srph @JefMari