Support empty (void) tags #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we might need to tell rollup to inline
|
|
@developit Yeah, this is why I mentioned to just copy paste contents of that module to the repo. |
|
@developit to inline it with rollup it seems that I need to use either node-resolve plugin or provide |
|
Yup, I'm totally cool with that. Think it's ready to merge with that inlined? edit: see comment |
developit
reviewed
Dec 8, 2016
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Actually maybe we can simplify the sanitize mapping:
s += `</${name}>`;
} else {
s += '>';
}
sanitized[s] = true;
return s;
}
|
I think ready to merge now (if you don't have any other comments). |
|
Looks great! |
|
Great, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@developit I'm actually not sure how it worked before without this feature, but it was producing things like
<input type="text"></input>which is kind of wrong markup (though browsers understand it..).In this PR I load list of empty tags from
empty-tagsmodule which I crated long time ago for OpenJSX. Though, if you think that it makes sense inline them directly into project (separate file but in the repo) then I'll do that.I intentionally don't do any warning here when child elements are added to elements empty elements, but if that makes sense we can probably do that with a
process.ENV === 'development'guard.