Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect proxy settings read when proxy specified in dwoc at start #865

Closed
amisevsk opened this issue Jun 9, 2022 · 0 comments · Fixed by #866
Closed

Incorrect proxy settings read when proxy specified in dwoc at start #865

amisevsk opened this issue Jun 9, 2022 · 0 comments · Fixed by #866
Milestone

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Jun 9, 2022

Description

Normally, on OpenShift, DWO reads the cluster proxy object on OpenShift to automatically configure the proxy used for both itself and workspaces. However, if the DevWorkspaceOperatorConfig proxy settings are not empty, DWO does not merge the cluster config and its own config at startup, resulting in only the DevWorkspaceOperatorConfig proxy settings being used.

This persists until the DevWorkspaceOperatorConfig is edited again, at which point the two are merged correctly and the proxy functions as intended.

How To Reproduce

Create the DevWorkspaceOperatorConfig in an OpenShift cluster with a proxy configured

apiVersion: controller.devfile.io/v1alpha1
kind: DevWorkspaceOperatorConfig
metadata:
  name: devworkspace-operator-config
config:
  routing:
    proxyConfig:
      noProxy: "test.no-proxy.com"

On startup, note that DWO logs

{"level":"info","ts":1654788202.0073922,"logger":"operator-configuration","msg":"Resolved proxy configuration","proxy":{"noProxy":"test.no-proxy.com"}}

ignoring whatever cluster settings are present. If you edit the DevWorkspaceOperatorConfig later, DWO will log the correct object, merging the cluster config and additional config.

Expected behavior

The two configs should be merged.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant