Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the per-workspace PVC do not trigger reconciles #881

Closed
amisevsk opened this issue Jul 1, 2022 · 0 comments · Fixed by #879
Closed

Changes to the per-workspace PVC do not trigger reconciles #881

amisevsk opened this issue Jul 1, 2022 · 0 comments · Fixed by #879
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Jul 1, 2022

Description

The DevWorkspace Operator does not watch PVCs for events, and so does not trigger reconciles if the PVC used by per-workspace DevWorkspaces is modified/deleted.

How To Reproduce

  1. Start a per-workspace DevWorkspace: oc apply -f samples/theia-next_per-workspaceStorage.yaml
  2. Wait for workspace to reach running state
  3. Edit the storage-<workspaceID> PVC by adding e.g. an annotation -- note no reconcile is triggered
  4. Delete the storage-<workspaceID> PVC and note that the DevWorkspace stays in the running state (it should fail to allow the PVC to be cleaned up)

Expected behavior

  • DWO should queue reconciles for the owner DevWorkspace when the PVC is modified
  • DWO should fail the per-workspace DevWorkspace if the PVC is deleted. This is pretty important as otherwise the running pod of the workspace will prevent the PVC from being cleaned up.

Additional context

@amisevsk amisevsk self-assigned this Jul 1, 2022
@amisevsk amisevsk linked a pull request Jul 1, 2022 that will close this issue
3 tasks
@amisevsk amisevsk mentioned this issue Jul 4, 2022
3 tasks
@amisevsk amisevsk added this to the v0.15.x milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant