Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s.io/utils/pointer to instantiate pointers throughout the codebase #958

Closed
AObuchow opened this issue Oct 24, 2022 · 0 comments · Fixed by #959
Closed

Use k8s.io/utils/pointer to instantiate pointers throughout the codebase #958

AObuchow opened this issue Oct 24, 2022 · 0 comments · Fixed by #959
Labels
good first issue Good for newcomers
Milestone

Comments

@AObuchow
Copy link
Collaborator

Description

Currently, throughout the DWO repo we are initializing variables so that they can be referenced as pointer values when needed, for example here.

Instead, we should make use of k8s.io/utils/pointer to instantiate pointers and reference them in a single statement.
For example, one can get a pointer that points to a boolean with the value true by doing: pointer.BoolPtr(true)

Additional context

Here is where this idea was initially suggested: #953 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants