-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use partial and content_for to wrap components in style guide #88
Open
ChristineP2
wants to merge
7
commits into
devnacho:master
Choose a base branch
from
ChristineP2:use-partial-with-content_for
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use partial and content_for to wrap components in style guide #88
ChristineP2
wants to merge
7
commits into
devnacho:master
from
ChristineP2:use-partial-with-content_for
+35
−4
Commits on Mar 24, 2019
-
Merge pull request #6 from devnacho/master
Get Latest from DevNacho
Configuration menu - View commit details
-
Copy full SHA for 0155f14 - Browse repository at this point
Copy the full SHA 0155f14View commit details -
Use
content_for
to allow wrappers in demoAdded the ability to have a partial in the meta. If partial exists, the component will be added to content_for with a name mv_#{component_name}_#{index} The partial will use mv_content_for_name to retrieve that specific content_for value and display it within the wrapper.
Configuration menu - View commit details
-
Copy full SHA for 14c3ac2 - Browse repository at this point
Copy the full SHA 14c3ac2View commit details -
Remove content_for block format
The content_for block format (as well as trying partial layout: component_stub.meta_partial to use a block format with :yield) resulted in the rails server exiting with an error code. Removing the block seems to have solved the issue.
Configuration menu - View commit details
-
Copy full SHA for 15dbc51 - Browse repository at this point
Copy the full SHA 15dbc51View commit details -
Added a bit of info about the partials to the readme
Configuration menu - View commit details
-
Copy full SHA for aa09f5a - Browse repository at this point
Copy the full SHA aa09f5aView commit details
Commits on May 10, 2019
-
This worked on the mac, now retesting in windows.
Configuration menu - View commit details
-
Copy full SHA for c545a5c - Browse repository at this point
Copy the full SHA c545a5cView commit details -
Trying rename partial as layout and changing to the example provided in the PR comments, in the hopes it will solve the server crash thing. (also got rid of the pink and added a bit of padding lol)
Configuration menu - View commit details
-
Copy full SHA for 619f132 - Browse repository at this point
Copy the full SHA 619f132View commit details -
Co-Authored-By: Esteban Pastorino <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5ab322d - Browse repository at this point
Copy the full SHA 5ab322dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.