Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use partial and content_for to wrap components in style guide #88

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Mar 24, 2019

  1. Merge pull request #6 from devnacho/master

    Get Latest from DevNacho
    ChristineP2 authored Mar 24, 2019
    Configuration menu
    Copy the full SHA
    0155f14 View commit details
    Browse the repository at this point in the history
  2. Use content_for to allow wrappers in demo

    Added the ability to have a partial in the meta.  If partial exists, the component will be added to content_for with a name mv_#{component_name}_#{index}
    
    The partial will use mv_content_for_name to retrieve that specific content_for value and display it within the wrapper.
    ChristineP2 committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    14c3ac2 View commit details
    Browse the repository at this point in the history
  3. Remove content_for block format

    The content_for block format (as well as trying partial layout: component_stub.meta_partial to use a block format with :yield) resulted in the rails server exiting with an error code.  Removing the block seems to have solved the issue.
    ChristineP2 committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    15dbc51 View commit details
    Browse the repository at this point in the history
  4. Update to Readme

    Added a bit of info about the partials to the readme
    ChristineP2 committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    aa09f5a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Use Block - Test for Windows

    This worked on the mac, now retesting in windows.
    ChristineP2 committed May 10, 2019
    Configuration menu
    Copy the full SHA
    c545a5c View commit details
    Browse the repository at this point in the history
  2. Renaming Partial

    Trying rename partial as layout and changing to the example provided in the PR comments, in the hopes it will solve the server crash thing. (also got rid of the pink and added a bit of padding lol)
    ChristineP2 committed May 10, 2019
    Configuration menu
    Copy the full SHA
    619f132 View commit details
    Browse the repository at this point in the history
  3. Update README.md

    Co-Authored-By: Esteban Pastorino <[email protected]>
    ChristineP2 and kitop authored May 10, 2019
    Configuration menu
    Copy the full SHA
    5ab322d View commit details
    Browse the repository at this point in the history