perf: simple simdjson solution with 30% speed increase #7316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlmcguire
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
karlmcguire
added
area/parsing
|
Deploy preview for dgraph-docs ready! Built with commit 06cb2f8 |
manishrjain
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
|
The only remaining issue is passing this test expecting an overflow error from a JSON number which just so happens to be the exact same number from Jepsen's 2018 analysis of Dgraph where the number automatically gets converted into a Unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler version of #7315 with reasonable speed improvement.
I've made
FastParseJSONthe default JSON parser (replacingencoding/json) and ifsimdjson.SupportedCPU()returns false we fallback toencoding/json.NOTE: This shouldn't be merged until simdjson-go merges this PR fixing number parsing issues. I'm in contact with the maintainer and it should be merged this weekend. If not, we can fork.
This change is