fix(GraphQL): Added error for case when multiple filter functions are used in filter.

[JatinDev543]

we were having indeterministic behavior in the filter when we have multiple filter functions as below .

query {
  queryFoo(filter:{value:{eq:2 le:2}})
     {
      value
    }
  }
  

It was because we were selecting the first filter function from the list of functions whose order is not guaranteed.
Now we are returning an error for this.

---

This change is 

[abhimanyusinghgaur]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @jatindevdg and @pawanrawal)

---

graphql/schema/validation_rules.go, line 28 at r1 (raw file):

var allowedFilters = []string{"StringHashFilter", "StringExactFilter", "StringFullTextFilter",
	"StringRegExpFilter", "StringTermFilter", "DateTimeFilter", "FloatFilter", "Int64Filter", "IntFilter"}

we should also add these filters to this list:

PointGeoFilter, ContainsFilter, IntersectsFilter, PolygonGeoFilter

---

graphql/schema/validation_rules.go, line 59 at r1 (raw file):

 value.ExpectedType == nil

don't see this being used, can we remove this check?

---

graphql/schema/validation_rules.go, line 64 at r1 (raw file):

Multiple filter functions for %s not allowed

%s filter expects only one filter function, got: %d

---

graphql/schema/validation_rules.go, line 183 at r1 (raw file):

Quoted 8 lines of code…

func contains(s []string, str string) bool {
	for _, v := range s {
		if v == str {
			return true
		}
	}
	return false
}

we can use x.HasString() instead of defining this

[JatinDev543]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @abhimanyusinghgaur and @pawanrawal)

---

graphql/schema/validation_rules.go, line 28 at r1 (raw file):

Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…

we should also add these filters to this list:

PointGeoFilter, ContainsFilter, IntersectsFilter, PolygonGeoFilter

done.

---

graphql/schema/validation_rules.go, line 59 at r1 (raw file):

Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…

 value.ExpectedType == nil

don't see this being used, can we remove this check?

removed.

---

graphql/schema/validation_rules.go, line 64 at r1 (raw file):

Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…

Multiple filter functions for %s not allowed

%s filter expects only one filter function, got: %d

changed.

---

graphql/schema/validation_rules.go, line 183 at r1 (raw file):

Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…

func contains(s []string, str string) bool {
	for _, v := range s {
		if v == str {
			return true
		}
	}
	return false
}

we can use x.HasString() instead of defining this

changed.